-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mob Spawner Rework #2848
Merged
rye-rice
merged 120 commits into
shiptest-ss13:master
from
FalloutFalcon:legion-rework-2
Jul 12, 2024
Merged
Mob Spawner Rework #2848
rye-rice
merged 120 commits into
shiptest-ss13:master
from
FalloutFalcon:legion-rework-2
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Suckerberg <[email protected]> Signed-off-by: FalloutFalcon <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to legion-rework-2
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to legion-rework-2
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Theos <[email protected]>
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> see title atomization of shiptest-ss13#2848 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> see title <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: del: Removed goofball legion disease /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> Co-authored-by: Sun-Soaked <[email protected]>
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> removes crusher trophies relevance from crushers. I didn't fully remove them because they are neat for crafting and.. as trophies atomization of shiptest-ss13#2848 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> miner power gamer cruft. Its not really needed when we are trying to balance stuff around guns. Crusher still remains the strongest mostly obtainable melee weapon. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: del: Trophies can no longer be used in crushers /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to legion-rework-2
shiptest-server
pushed a commit
that referenced
this pull request
Jul 12, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Jul 13, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> reworks most mob spawners to fall under a much simpler spawner/burrow each planet has one simple nest instead of the old system with difficultly levels i never even noticed were there despite the fact i used to basically just kill nests and powergame when i first played this has the byproduct of killing off all the awful magic item spawns attacking a bunch of other cruft, mostly lavaland <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: add: A new generic nest used across all planets del: Old portal and tendrils and other cruft refactor: refactorted mob spawners to have one for each planet /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <[email protected]> Signed-off-by: Theos <[email protected]> Co-authored-by: Mark Suckerberg <[email protected]> Co-authored-by: Theos <[email protected]>
FalloutFalcon
added a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Aug 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request reworks most mob spawners to fall under a much simpler spawner/burrow each planet has one simple nest instead of the old system with difficultly levels i never even noticed were there despite the fact i used to basically just kill nests and powergame when i first played this has the byproduct of killing off all the awful magic item spawns attacking a bunch of other cruft, mostly lavaland <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: A new generic nest used across all planets del: Old portal and tendrils and other cruft refactor: refactorted mob spawners to have one for each planet /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <[email protected]> Signed-off-by: Theos <[email protected]> Co-authored-by: Mark Suckerberg <[email protected]> Co-authored-by: Theos <[email protected]>
FalloutFalcon
pushed a commit
to FalloutFalcon/ShiptestF
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code change
Watch something violently break.
DME Edit
Map Change
Tile placing is hard. Thank you for your service.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
reworks most mob spawners to fall under a much simpler spawner/burrow
each planet has one simple nest instead of the old system with difficultly levels i never even noticed were there despite the fact i used to basically just kill nests and powergame when i first played
this has the byproduct of killing off all the awful magic item spawns
attacking a bunch of other cruft, mostly lavaland
Why It's Good For The Game
Changelog
🆑
add: A new generic nest used across all planets
del: Old portal and tendrils and other cruft
refactor: refactorted mob spawners to have one for each planet
/:cl: